From 9fd3b6d0870504d8a73871cacf986fff5eb6b070 Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Sat, 8 Aug 2020 10:23:43 -0700 Subject: [PATCH] Girocco/Project.pm: add missing parentheses Make sure the unlink call only gobbles up the one argument it's intended to take by adding a pair of parentheses. Signed-off-by: Kyle J. McKay --- Girocco/Project.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Girocco/Project.pm b/Girocco/Project.pm index 10c88b3..997c393 100644 --- a/Girocco/Project.pm +++ b/Girocco/Project.pm @@ -550,7 +550,7 @@ sub _hook_install { umask($oldmask); my $globalhooks = $Girocco::Config::reporoot . "/_global/hooks"; -f "$globalhooks/$name" && -r _ or die "cannot find hook $name: $!"; - ! -e $self->_hook_path($name) || unlink $self->_hook_path($name) && ! -e $self->_hook_path($name) or + ! -e $self->_hook_path($name) || unlink($self->_hook_path($name)) && ! -e $self->_hook_path($name) or die "hooks directory contains unremovable pre-existing hook $name: $!"; symlink("$globalhooks/$name", $self->_hook_path($name)) or die "cannot create hook $name symlink: $!"; -- 2.11.4.GIT