From 8f1cbae4b408ced3399912e471182240c80026d9 Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Sun, 4 Jul 2021 19:03:30 -0700 Subject: [PATCH] Girocco/Config.pm: mention Git's reference-transaction hook The reference-transaction hook added in Git v2.28.0 makes most of what the $autogchack does unnecessary. However, based on an unfortunate design decision in the implemenation of the reference-transaction hook, Girocco still must keep track of the old value of any updated refs to generate the correct change notices. It does this anyway for all mirrors already, not a big deal. For now, just mention that the reference-transaction hook has been available since Git v2.28.0; eventually, changes will be made to take advantage of the new hook to obsolete the $autogchack setting when running with a Git >= 2.28.0. Signed-off-by: Kyle J. McKay --- Girocco/Config.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Girocco/Config.pm b/Girocco/Config.pm index 3f4f937..3d1123b 100644 --- a/Girocco/Config.pm +++ b/Girocco/Config.pm @@ -1106,7 +1106,8 @@ our $fetch_stash_refs = undef; # When set to a true value, Girocco will attempt to pick up ref changes made # outside of Girocco itself and process them using the usual Girocco # notification mechanism. Git lacks any "post-ref-change" hook capability that -# could facilitate this. This feature is primarily intended to detect running +# could facilitate this prior to the introduction of the reference-transation +# hook in Git v2.28.0. This feature is primarily intended to detect running # of "git fetch" in linked working trees of a Girocco repository. In many # cases after running a command Git runs "git gc --auto". With the correct # encouragement we can always induce Git to run our pre-auto-gc hook at that -- 2.11.4.GIT